Fix String#index and #rindex for Char::REPLACEMENT#14937
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Aug 25, 2024
Merged
Fix String#index and #rindex for Char::REPLACEMENT#14937straight-shoota merged 1 commit intocrystal-lang:masterfrom
String#index and #rindex for Char::REPLACEMENT#14937straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Aug 23, 2024
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
While at it, we could also add specs for searching for Char::REPLACEMENT in a string that is not single_byte_optimizable.
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/crystal-1-13-3-is-released/7191/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the string consists only of ASCII characters and invalid UTF-8 byte sequences, all the latter should correspond to
Char::REPLACEMENT, and so#indexand#rindexshould detect them, but this was broken since #14461.