Optimize String#index(Char) and #rindex(Char) for invalid UTF-8#14461
Merged
straight-shoota merged 5 commits intocrystal-lang:masterfrom Apr 17, 2024
Merged
Optimize String#index(Char) and #rindex(Char) for invalid UTF-8#14461straight-shoota merged 5 commits intocrystal-lang:masterfrom
String#index(Char) and #rindex(Char) for invalid UTF-8#14461straight-shoota merged 5 commits intocrystal-lang:masterfrom
Conversation
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Sija
reviewed
Apr 9, 2024
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
straight-shoota
approved these changes
Apr 9, 2024
1 task
straight-shoota
pushed a commit
that referenced
this pull request
Aug 25, 2024
straight-shoota
pushed a commit
that referenced
this pull request
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
str.single_byte_optimizable?is true, thenstrcontains only ASCII characters and invalid UTF-8 byte sequences, therefore we can immediately reject any non-ASCII codepoint.