Skip to content

Fix explicitly clear deleted Hash::Entry #14862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Aug 5, 2024
Merged

Fix explicitly clear deleted Hash::Entry #14862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/hash.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,8 @@ class Hash(K, V)
# Marks an entry in `@entries` at `index` as deleted
# *without* modifying any counters (`@size` and `@deleted_count`).
private def delete_entry(index) : Nil
set_entry(index, Entry(K, V).deleted)
# sets `Entry#@hash` to 0 and removes stale references to key and value
(@entries + index).clear
end

# Marks an entry in `@entries` at `index` as deleted
Expand Down Expand Up @@ -2154,12 +2155,6 @@ class Hash(K, V)
def initialize(@hash : UInt32, @key : K, @value : V)
end

def self.deleted
key = uninitialized K
value = uninitialized V
new(0_u32, key, value)
end

def deleted? : Bool
@hash == 0_u32
end
Expand Down