Skip to content

Fix explicitly clear deleted Hash::Entry#14862

Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:perf/hash-delete
Aug 5, 2024
Merged

Fix explicitly clear deleted Hash::Entry#14862
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:perf/hash-delete

Conversation

@HertzDevil
Copy link
Contributor

Fixes #14859

@straight-shoota straight-shoota added this to the 1.14.0 milestone Aug 2, 2024
@beta-ziliani
Copy link
Member

Note: The failing window test is unrelated

@straight-shoota straight-shoota changed the title Always clear deleted keys and values in Hash Fix explicitly clear deleted Hash::Entry Aug 5, 2024
@straight-shoota straight-shoota merged commit 43e4f1d into crystal-lang:master Aug 5, 2024
@HertzDevil HertzDevil deleted the perf/hash-delete branch August 5, 2024 14:46
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. and removed performance labels Aug 14, 2024
@straight-shoota straight-shoota modified the milestones: 1.14.0, 1.13.2 Aug 15, 2024
@crysbot
Copy link
Collaborator

crysbot commented Aug 21, 2024

This pull request has been mentioned on Crystal Forum. There might be relevant details there:

https://forum.crystal-lang.org/t/crystal-1-13-2-is-released/7110/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Hash do not clean references to objects in --release mode

6 participants