Fix stats and progress issues in codegen#14763
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Jul 1, 2024
Merged
Fix stats and progress issues in codegen#14763straight-shoota merged 3 commits intocrystal-lang:masterfrom
straight-shoota merged 3 commits intocrystal-lang:masterfrom
Conversation
- progress isn't updated when `--threads=1` (always true on Windows); - progress doesn't need to collect reused modules (only stats do).
ysbaddaden
added
kind:bug
straight-shoota
approved these changes
Jun 28, 2024
Collaborator
Author
|
@sdogruyol I assume you faced the issue? |
Member
Yes, I recently experienced |
Collaborator
Author
|
Merged with master to fix conflict with #14762. |
straight-shoota
changed the title
straight-shoota
pushed a commit
that referenced
this pull request
Jul 2, 2024
The `--stats` and `--progress` params had a couple issues: - codegen progress isn't updated when `--threads=1` (always the case on Windows); - only stats need to collect reused modules (progress doesn't).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--statsand--progressparams had a couple issues:--threads=1(always the case on Windows);Idea for a follow-up: the report fiber of forked codegen could set
unit.reused_previous_compilationinstead of collecting reused module names, then we wouldn't need to collect the module names into a reused array (we can trustunitsto be updated) and the#print_codegen_statsmethod would count & filter has needed.