Fix: init schedulers before we spawn fibers#14339
Merged
ysbaddaden merged 1 commit intocrystal-lang:masterfrom Mar 1, 2024
Merged
Fix: init schedulers before we spawn fibers#14339ysbaddaden merged 1 commit intocrystal-lang:masterfrom
ysbaddaden merged 1 commit intocrystal-lang:masterfrom
Conversation
The signal and interrupt handlers spawn fibers, and should thus be setup after we properly start the fiber schedulers... This is only working today because we lazily start schedulers for a thread, and we don't have any dual dependencies.
ysbaddaden
added
kind:bug
straight-shoota
approved these changes
Feb 29, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signal and interrupt handlers spawn fibers, and should thus be setup after we properly start the fiber schedulers.
This is working today because we lazily start schedulers for a thread, and we happen to not have recursive dependencies, but crystal-lang/rfcs#2 is a whole different story 😅