Merged
Conversation
✅ Deploy Preview for crystal-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
33 tasks
beta-ziliani
requested changes
Apr 9, 2024
Member
beta-ziliani
left a comment
There was a problem hiding this comment.
I left some fixes.
Overall I think it's too detailed and people might get bored and miss the important bits. I rather remove bugfixes/improvements without much impact on the final user. This is a proposed list of things to remove:
- Init schedulers before we spawn fibers (#14339).
- Use per-scheduler stack pools (let’s recycle) (#14100).
- Reserve stack space on non-main threads for crash recovery on Windows (#14187).
(Maybe move it to the Windows section?) - Make equality between Complex and other numbers exact (#14309).
- Fix #hash for the Big* number types (#14308).
- Handle invalid parameter error in MSVC calls to prevent an immediate process exit (#14313)
- Crystal::System::FileDescriptor::Handle is a generic alias to the platform-specific type representing a file descriptor (#14390)
- Hash#update (#14417) and Hash#put_if_absent (#14427) no longer put duplicate keys if the block inserts the key.
- FileUtils.mv works across filesystems on Windows (#14320).
(Maybe move to Windows section?)
And I'd just mention the several fixes in the formatter without being explicit.
Co-authored-by: Beta Ziliani <beta@manas.tech>
Member
Author
|
I dropped some of the less relevant bug fixes. But many that you mentioned are part of the current projects Concurrency/MT and Windows. I think it makes sense to mention a bit more details what's going on there. |
beta-ziliani
approved these changes
Apr 9, 2024
asterite
reviewed
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.