Do not allocate memory in the segmentation fault signal handler#14327
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Feb 29, 2024
Merged
Conversation
Member
|
Perhaps you could add a comment about that to the |
Sija
reviewed
Feb 28, 2024
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
straight-shoota
approved these changes
Feb 28, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
String.new(UInt8*)call insideException::CallStack.decode_framecould allocate memory, potentially triggering a GC cycle or expanding the GC heap, which could break the stack trace:This seems to happen on master since #14257, and also to #14047 with Crystal 1.10.1. This PR removes this allocation so that
Crystal::System::Signal.@@segfault_handlershould be allocation-free. (TechnicallyFiber.currentcould eventually callThread.new, but this should be extremely rare.)