Thread: set name#14257
Merged
straight-shoota merged 7 commits intocrystal-lang:masterfrom Jan 30, 2024
Merged
Conversation
This allows to identify the thread by name, including in system applications, such as `top -H` or `gdb` sessions.
yxhuvud
reviewed
Jan 26, 2024
Sija
reviewed
Jan 26, 2024
HertzDevil
reviewed
Jan 26, 2024
HertzDevil
requested changes
Jan 28, 2024
Also enables the android target, though it may not work and one may have to use JNI instead. See https://stackoverflow.com/questions/50327631/android-ndk-setting-a-name-for-a-c-thread
straight-shoota
approved these changes
Jan 29, 2024
HertzDevil
approved these changes
Jan 29, 2024
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to identify the thread by name, including in system applications, such as
top -Horgdbsessions. For example with MT:4 we can see the main crystal thread (not renamed), the 7 GC threads, and the 3 MT threads.EDIT: the scheduler threads are now named
CRYSTAL-MT-inotmt-i(unlike the screenshot).