Skip to content

Make FileUtils.mv work across filesystems on Windows#14320

Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:bug/file-utils-mv-cross-device
Feb 26, 2024
Merged

Make FileUtils.mv work across filesystems on Windows#14320
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:bug/file-utils-mv-cross-device

Conversation

@HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Feb 25, 2024

Fixes #7777.

Note that LibC.MoveFileExW does accept a MOVEFILE_COPY_ALLOWED flag that performs the same for files, but it doesn't work for directories, so there is little point in using the flag.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files labels Feb 25, 2024
@straight-shoota straight-shoota added this to the 1.12.0 milestone Feb 25, 2024
@straight-shoota straight-shoota merged commit 54a3279 into crystal-lang:master Feb 26, 2024
@HertzDevil HertzDevil deleted the bug/file-utils-mv-cross-device branch February 27, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

FileUtils.mv does not work like its Ruby counterpart

2 participants