Skip to content

Add CRYSTAL_CONFIG_LIBRARY_RPATH compiler config #14319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
straight-shoota wants to merge 1 commit into from
Closed

Add CRYSTAL_CONFIG_LIBRARY_RPATH compiler config #14319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/crystal/codegen/link.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ module Crystal
def self.default_rpath : String
# do not call `CrystalPath.expand_paths`, as `$ORIGIN` inside this env
# variable is always expanded at run time
ENV.fetch("CRYSTAL_LIBRARY_RPATH", "")
ENV.fetch("CRYSTAL_LIBRARY_RPATH", {{ env("CRYSTAL_CONFIG_LIBRARY_RPATH") || "" }})
Copy link
Copy Markdown
Contributor

@Sija Sija Feb 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add it into Crystal::Config as in the library_path case?

Copy link
Copy Markdown
Member Author

@straight-shoota straight-shoota Feb 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to merge this with little friction. We can refactor it later.

end

# Adds the compiler itself's RPATH to the environment for the duration of
Expand Down