Add CRYSTAL_CONFIG_LIBRARY_RPATH compiler config#14319
Add CRYSTAL_CONFIG_LIBRARY_RPATH compiler config#14319straight-shoota wants to merge 1 commit intocrystal-lang:masterfrom
CRYSTAL_CONFIG_LIBRARY_RPATH compiler config#14319Conversation
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/crystal-installation-using-linuxbrew-is-not-working/6559/15 |
| # do not call `CrystalPath.expand_paths`, as `$ORIGIN` inside this env | ||
| # variable is always expanded at run time | ||
| ENV.fetch("CRYSTAL_LIBRARY_RPATH", "") | ||
| ENV.fetch("CRYSTAL_LIBRARY_RPATH", {{ env("CRYSTAL_CONFIG_LIBRARY_RPATH") || "" }}) |
There was a problem hiding this comment.
Why not add it into Crystal::Config as in the library_path case?
There was a problem hiding this comment.
I want to merge this with little friction. We can refactor it later.
|
So with the future of the target var questionable, it's not clear if adding this configuration variable really makes sense. I suppose it wouldn't hurt. So we can merge it and if #14318 should be enough to solve the original problem this was supposed to fix. So this isn't strictly necessary for the intended use case. |
3 participants
It's already possible to configure the default value for
CRYSTAL_LIBRARY_PATH. This PR adds the same forCRYSTAL_LIBRARY_RPATH. I had already assumed this would work by trying to use it in the homebrew formula. https://forum.crystal-lang.org/t/crystal-installation-using-linuxbrew-is-not-working/6559/6?u=straight-shootaBut it doesn't. So time change that!