Reserve stack space on non-main threads for crash recovery on Windows#14187
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Jan 12, 2024
Merged
Conversation
beta-ziliani
approved these changes
Jan 8, 2024
ysbaddaden
approved these changes
Jan 8, 2024
Contributor
|
For posterity, can you update the OP to show what the stack trace looked like before your change? |
Contributor
Author
|
Contributor
|
Ah thanks...I thought it was more complicated than that 😆 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LibC.SetThreadStackGuaranteeonly works on the current thread. This PR extends it to other threads created explicitly or via-Dpreview_mt, so that stack overflows on them will print a stack trace properly: