Handle formatting annotated method parameters#12446
Merged
beta-ziliani merged 4 commits intocrystal-lang:masterfrom Sep 7, 2022
Merged
Handle formatting annotated method parameters#12446beta-ziliani merged 4 commits intocrystal-lang:masterfrom
beta-ziliani merged 4 commits intocrystal-lang:masterfrom
Conversation
Blacksmoke16
added
kind:bug
Sija
reviewed
Sep 4, 2022
straight-shoota
approved these changes
Sep 5, 2022
Sija
reviewed
Sep 5, 2022
beta-ziliani
approved these changes
Sep 5, 2022
beta-ziliani
approved these changes
Sep 6, 2022
Member
Author
|
Should this go into |
beta-ziliani
pushed a commit
to beta-ziliani/crystal
that referenced
this pull request
Sep 7, 2022
Also added an optional focus parameter to assert_format to make debugging a specific failure a bit easier. Fixes formatter after crystal-lang#12044.
beta-ziliani
pushed a commit
that referenced
this pull request
Sep 7, 2022
Also added an optional focus parameter to assert_format to make debugging a specific failure a bit easier. Fixes formatter after #12044.
beta-ziliani
pushed a commit
that referenced
this pull request
Sep 7, 2022
Also added an optional focus parameter to assert_format to make debugging a specific failure a bit easier. Fixes formatter after #12044.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be able to clean up the logic a bit, but this seems to cover all the specs I threw at it. So good enough for now. Also added an optional
focusparameter toassert_formatto make debugging a specific failure a bit easier.Fixes formatter after #12044.