Skip to content

Document new annotation/macro features#636

Merged
beta-ziliani merged 4 commits intocrystal-lang:masterfrom
Blacksmoke16:new-macro-features
Sep 8, 2022
Merged

Document new annotation/macro features#636
beta-ziliani merged 4 commits intocrystal-lang:masterfrom
Blacksmoke16:new-macro-features

Conversation

@Blacksmoke16
Copy link
Copy Markdown
Member

@Blacksmoke16 Blacksmoke16 commented Sep 4, 2022

Depends on crystal-lang/crystal#12446

Document `parse_type` method
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 4, 2022

Deploy Preview for crystal-book ready!

Name Link
🔨 Latest commit 14d48ff
🔍 Latest deploy log https://app.netlify.com/sites/crystal-book/deploys/631a45f20106b20009e137cd
😎 Deploy Preview https://deploy-preview-636--crystal-book.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Blacksmoke16 Blacksmoke16 marked this pull request as draft September 4, 2022 18:51
@Blacksmoke16
Copy link
Copy Markdown
Member Author

Moving this to draft as it seems there a formatter bug with annotations on parameters :/

@Blacksmoke16
Copy link
Copy Markdown
Member Author

Blacksmoke16 commented Sep 4, 2022

Okay, so opened a PR to fix the formatter. But not sure how we want to proceed. I.e. ignore the failure and merge as is, or wait until next Crystal release that includes the fix before merging.

Co-authored-by: Beta Ziliani <beta@manas.tech>
@Blacksmoke16 Blacksmoke16 marked this pull request as ready for review September 8, 2022 19:43
@beta-ziliani beta-ziliani merged commit 69a569a into crystal-lang:master Sep 8, 2022
@Blacksmoke16 Blacksmoke16 deleted the new-macro-features branch September 8, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants