Refactor index / count normalization in range-like methods#10753
Merged
straight-shoota merged 6 commits intocrystal-lang:masterfrom Jun 17, 2021
Merged
Conversation
straight-shoota
approved these changes
May 28, 2021
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
This is a great simplification, thanks!
oprypin
reviewed
May 31, 2021
oprypin
reviewed
Jun 4, 2021
oprypin
approved these changes
Jun 5, 2021
asterite
approved these changes
Jun 5, 2021
Member
asterite
left a comment
asterite
left a comment
There was a problem hiding this comment.
Looks great! It seems there are merge conflicts.
Member
|
@HertzDevil this needs an update again |
…e-start-and-count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor captures the index / count normalization in many
Indexablemethods and some others outside; it is the range-like equivalent ofIndexable#check_index_out_of_bounds.Related to #10243. (Any method that uses
normalize_start_and_countorrange_to_index_and_countwill have the same index behaviour noted there.)There are at least two methods where this refactor does not apply, because they require exactly
countelements and not "countor less" elements:Array(T)#fill(value : T, from : Int, count : Int)Slice(T)#[]?(start : Int, count : Int)