forked from evmos/ethermint
-
Notifications
You must be signed in to change notification settings - Fork 53
fix: staking optimization #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
randy-cro
wants to merge
1
commit into
crypto-org-chain:develop
Choose a base branch
from
randy-cro:fix/staking-optimization
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: staking optimization #776
randy-cro
wants to merge
1
commit into
crypto-org-chain:develop
from
randy-cro:fix/staking-optimization
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
13 tasks
cce6d25 to
40aeba2
Compare
40aeba2 to
1cf0a6b
Compare
b8fac92 to
abe8ab3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #776 +/- ##
===========================================
+ Coverage 46.85% 46.97% +0.12%
===========================================
Files 189 190 +1
Lines 15353 15389 +36
===========================================
+ Hits 7193 7229 +36
Misses 7361 7361
Partials 799 799
🚀 New features to boost your workflow:
|
abe8ab3 to
200a3fa
Compare
13 tasks
b94ff4d to
b415fd7
Compare
JayT106
approved these changes
Nov 18, 2025
JayT106
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c2ed3da to
b13c640
Compare
b13c640 to
bafd25a
Compare
bafd25a to
b496284
Compare
b496284 to
e4eaba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch introduces a fixed gas consumption decorator in the antehandler to standardize gas usage for whitelisted messages.
Currently, only staking-related messages are included in the whitelist.
Purpose
This ensures consistent gas consumption across all nodes, regardless of variations in staking cache size.
By normalizing gas usage, it prevents potential AppHash mismatches caused by potential node-specific cache sizes.
Implementation Details
For example, the mean gas used for
MsgUndelegatecan be referenced here:Mainnet reference
This change works in tandem with the staking cache introduced in the Cosmos SDK:
crypto-org-chain/cosmos-sdk#1733
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)