-
Notifications
You must be signed in to change notification settings - Fork 273
fix: staking optimization v1.6.x patch #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v1.6.x-optstaking
Are you sure you want to change the base?
fix: staking optimization v1.6.x patch #1910
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
a252593 to
287bb38
Compare
287bb38 to
9128ce5
Compare
| github.com/cosmos/cosmos-proto v1.0.0-beta.5 | ||
| github.com/cosmos/cosmos-sdk v0.53.0 | ||
| github.com/cosmos/gogoproto v1.7.0 | ||
| github.com/cosmos/gogoproto v1.7.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there so many dependency updates?
Description
Previous staking optimizations were causing AppHash mismatches across nodes.
To address this issue, two key changes were introduced:
Use of an in-memory KV store to manage staking caches.
Reference
Implementation of fixed gas consumption for staking-related messages to ensure consistent gas usage.
Reference
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)