Problem: go version is outdated

[mmsqe]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

update to go 1.23.3

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• Chores
  • Updated Nix package channel from nixos-22.11 to nixos-24.11 across GitHub Actions workflows
  • Updated Nix package sources and references to newer versions
  • Upgraded Go build modules from Go 1.21 to Go 1.22
  • Updated nixpkgs and poetry2nix package references

[coderabbitai]

Walkthrough

This pull request focuses on updating the Nix package channel and Go build modules across multiple configuration files. The changes primarily involve upgrading from NixOS 22.11 to 24.11 in GitHub Actions workflow files, updating the Nixpkgs input in flake.nix to release-25.05, and modifying the Go build modules in nix/default.nix from Go 1.21 to Go 1.22. The modifications ensure consistent package management and build environments across the project's infrastructure.

Changes

File	Change Summary
.github/workflows/*	Updated nix_path from channel:nixos-22.11 to channel:nixos-24.11 in build, lint, test, and release workflows
flake.nix	Changed nixpkgs.url from release-24.05 to release-25.05
nix/default.nix	- Upgraded buildGoModule from buildGo121Module to buildGo122Module - Modified GOWORK environment variable definition
nix/sources.json	Updated nixpkgs and poetry2nix package references with new revisions and checksums

Possibly related PRs

• Problem: rustc in nixpkgs is too old #1469: Updates the nixpkgs version to 24.05, related to the Nix package management changes

Suggested reviewers

• calvinaco
• yihuang
• devashishdxt

Poem

🐰 Hopping through Nix channels bright,
Upgrading packages with delight,
From twenty-two to twenty-four we leap,
Go modules dancing, versions deep,
A rabbit's build, now swift and light! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ebf305 and b32381e.

⛔ Files ignored due to path filters (1)

• flake.lock is excluded by !**/*.lock

📒 Files selected for processing (7)

• .github/workflows/build.yml (4 hunks)
• .github/workflows/lint.yml (3 hunks)
• .github/workflows/release.yml (2 hunks)
• .github/workflows/test.yml (3 hunks)
• flake.nix (1 hunks)
• nix/default.nix (2 hunks)
• nix/sources.json (2 hunks)

✅ Files skipped from review due to trivial changes (4)

• .github/workflows/lint.yml
• .github/workflows/build.yml
• flake.nix
• .github/workflows/release.yml

⏰ Context from checks skipped due to timeout of 90000ms (11)

• GitHub Check: integration_tests (gas)
• GitHub Check: integration_tests (slow)
• GitHub Check: integration_tests (upgrade)
• GitHub Check: integration_tests (gov)
• GitHub Check: integration_tests (ica)
• GitHub Check: integration_tests (ibc_update_client)
• GitHub Check: integration_tests (ibc_timeout)
• GitHub Check: integration_tests (ibc_rly_gas)
• GitHub Check: integration_tests (ibc_rly_evm)
• GitHub Check: integration_tests (ibc)
• GitHub Check: integration_tests (unmarked)

🔇 Additional comments (5)

nix/default.nix (2)

68-74: Ensure consistent Go version across all build modules

The rly package is also updated to Go 1.22, which maintains consistency. The GOWORK environment variable syntax change improves clarity.

---

18-18: Version mismatch with PR objective

The PR objective states updating to Go 1.23.3, but this change updates to Go 1.22. Note that Go 1.23.3 is not a valid version as Go follows semantic versioning with even minor versions for stable releases.

.github/workflows/test.yml (1)

40-40: Consistent Nix channel update across all jobs

The Nix channel is consistently updated to nixos-24.11 across all jobs in the workflow.

Also applies to: 97-97, 121-121

nix/sources.json (2)

117-121: Verify poetry2nix compatibility

The poetry2nix update should be tested to ensure Python dependencies continue to work correctly.

✅ Verification successful

poetry2nix update appears safe to proceed

The poetry2nix integration is only used for setting up the Python test environment (integration_tests) with standard features and explicit Python 3.11 specification. No complex or version-specific features are being used that could be affected by this update.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for Python-related files that might be affected
fd -e py -e pyproject.toml -e poetry.lock

Length of output: 2720

---

Script:

#!/bin/bash
# Check for Nix files that might use poetry2nix
fd -e nix | xargs rg -l "poetry2nix"

# Also check if there are any Python requirements files as alternative to Poetry
fd "requirements.txt|setup.py"

Length of output: 175

---

Script:

#!/bin/bash
# Check how poetry2nix is used in the main Nix files
echo "=== flake.nix ==="
rg -A 5 -B 5 "poetry2nix" flake.nix

echo -e "\n=== nix/default.nix ==="
rg -A 5 -B 5 "poetry2nix" nix/default.nix

echo -e "\n=== nix/testenv.nix ==="
rg -A 5 -B 5 "poetry2nix" nix/testenv.nix

Length of output: 1877

---

100-109: Verify compatibility with nixpkgs release-25.05

The update to nixpkgs release-25.05 is a significant change. Please ensure all dependencies are compatible with this version.

✅ Verification successful

✓ nixpkgs update to release-25.05 is safe

The update is consistent across all Nix configurations. Both flake-based and legacy builds use the same version, and all dependent packages (poetry2nix, gomod2nix) follow the same nixpkgs input. No conflicting version constraints found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any dependency conflicts
nix-env -f . -qa --json \
  | jq -r 'to_entries[] | select(.value.broken == true or .value.unfree == true) | .key'

Length of output: 210

---

Script:

#!/bin/bash
# Find all Nix configuration files
fd -e nix

# Look for specific package version pins
rg -l "nixpkgs\." --type nix

Length of output: 632

---

Script:

#!/bin/bash
# Check flake.nix for nixpkgs configuration
echo "=== flake.nix ===" && cat flake.nix

# Check main nix configuration
echo -e "\n=== nix/default.nix ===" && cat nix/default.nix

# Check sources configuration
echo -e "\n=== nix/sources.nix ===" && cat nix/sources.nix

Length of output: 12392

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.10%. Comparing base (a3c2f70) to head (cbe40f2).
Report is 27 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
+ Coverage   16.87%   17.10%   +0.23%     
==========================================
  Files          72       74       +2     
  Lines        6163     6184      +21     
==========================================
+ Hits         1040     1058      +18     
- Misses       5000     5002       +2     
- Partials      123      124       +1     

[yihuang]

Do we still need the override in build overlay after bump nixpkgs?

[mmsqe]

actually bump nixpkgs is optional after we have newer overlay :D

[yihuang]

then let's wait for the overrides get included before bump?