Problem: rustc in nixpkgs is too old#1469
Conversation
WalkthroughThe recent changes focus on refining integration tests and dependency management. Key updates include removing redundant Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1469 +/- ##
===========================================
- Coverage 35.85% 17.54% -18.32%
===========================================
Files 136 87 -49
Lines 9806 5273 -4533
===========================================
- Hits 3516 925 -2591
+ Misses 5894 4238 -1656
+ Partials 396 110 -286 |
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
integration_tests/poetry.lockis excluded by!**/*.lock
Files selected for processing (6)
- integration_tests/configs/ibc.jsonnet (1 hunks)
- integration_tests/configs/ibc_rly.jsonnet (1 hunks)
- integration_tests/cosmoscli.py (4 hunks)
- integration_tests/pyproject.toml (1 hunks)
- nix/default.nix (1 hunks)
- nix/sources.json (4 hunks)
Files skipped from review due to trivial changes (1)
- integration_tests/configs/ibc_rly.jsonnet
Additional comments not posted (5)
nix/default.nix (1)
11-11: Update tobuildGo121Modulelooks good. Ensure all dependencies ofgo-ethereumare compatible with Go 1.21.integration_tests/configs/ibc.jsonnet (1)
Line range hint
1-1: Removal ofclient_configsections seems aligned with simplifying configurations. Verify that this does not adversely affect any dependent systems or processes.nix/sources.json (1)
8-11: Updates to the sources with new revisions and hashes are noted. Ensure the integrity of the sources by verifying the SHA-256 hashes match the actual content of the downloaded files.Also applies to: 57-60, 81-84, 105-108
integration_tests/cosmoscli.py (2)
Line range hint
347-364: The updated error handling in thetransfermethod improves robustness by checking transaction response codes and querying events based on the transaction hash. Ensure that theevent_query_tx_formethod correctly handles all possible cases.
Line range hint
1561-1576: The changes in theregister_counterparty_payeemethod enhance error handling by checking the transaction response code and querying events based on the transaction hash if the code is 0. Verify that theevent_query_tx_formethod is robust and handles all edge cases effectively.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
integration_tests/poetry.lockis excluded by!**/*.lock
Files selected for processing (1)
- integration_tests/pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (1)
- integration_tests/pyproject.toml
update nixpkgs to 24.05 that contains rustc 1.76.0
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Bug Fixes
Chores
pyyamlas a development dependency for integration tests.Refactor
client_configsections from validator configurations for cleaner setup.