fix(app): RootMultiStore interface and version mismatch #1179
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| name: Tests | ||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - master | ||
| - release/** | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test-versiondb: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.22 | ||
| check-latest: true | ||
| - uses: actions/checkout@v4 | ||
| - name: Install RocksDB Dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get -y install -y build-essential libsnappy-dev zlib1g-dev libbz2-dev libgflags-dev liblz4-dev libzstd-dev cmake | ||
| - name: Build and Install RocksDB | ||
| run: | | ||
| git clone https://github.com/facebook/rocksdb.git | ||
|
Contributor
Author
There was a problem hiding this comment. this is a temp solution. It's better to use nix, but I don't know how to use nix.
Contributor
There was a problem hiding this comment. maybe you call look at this
Contributor
Author
There was a problem hiding this comment.
Yes, I used this in nix.yml#407, it has some problems when linkeing rocksdb. let me look into versiondb prs in the cronos project first |
||
| cd rocksdb | ||
| git checkout v9.2.1 | ||
| mkdir build && cd build | ||
| cmake .. -DCMAKE_BUILD_TYPE=Release -DWITH_SNAPPY=ON -DWITH_LZ4=ON -DWITH_ZLIB=ON -DWITH_ZSTD=ON | ||
| sudo make -j4 | ||
| sudo make install | ||
| - uses: technote-space/get-diff-action@v6.1.2 | ||
| with: | ||
| PATTERNS: | | ||
| **/**.sol | ||
| **/**.go | ||
| go.mod | ||
| go.sum | ||
| - name: Test and Create Coverage Report | ||
| run: | | ||
| export COSMOS_BUILD_OPTIONS=rocksdb | ||
| make test-versiondb | ||
| if: env.GIT_DIFF | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| //go:build rocksdb | ||
| // +build rocksdb | ||
|
|
||
| package app_test | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| dbm "github.com/cosmos/cosmos-db" | ||
| "github.com/crypto-org-chain/chain-main/v4/app" | ||
|
|
||
| "cosmossdk.io/log" | ||
|
|
||
| "github.com/cosmos/cosmos-sdk/client/flags" | ||
| "github.com/cosmos/cosmos-sdk/server" | ||
| simtestutil "github.com/cosmos/cosmos-sdk/testutil/sims" | ||
| simcli "github.com/cosmos/cosmos-sdk/x/simulation/client/cli" | ||
| ) | ||
|
|
||
| func TestVersionDB(t *testing.T) { | ||
| db := dbm.NewMemDB() | ||
|
|
||
| appOptions := make(simtestutil.AppOptionsMap, 0) | ||
| appOptions[flags.FlagHome] = app.DefaultNodeHome | ||
| appOptions[server.FlagInvCheckPeriod] = simcli.FlagPeriodValue | ||
| appOptions["versiondb.enable"] = true | ||
| logger := log.NewNopLogger() | ||
| _ = app.New(logger, db, nil, false, appOptions, nil...) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it still work in progress?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't resolve this， so I used temporary solution in test.yml