Skip to content

Conversation

@songgaoye
Copy link
Contributor

@songgaoye songgaoye commented Jul 31, 2025

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

solution:
update memival,store,versondb
related prs
crypto-org-chain/cronos#1684
crypto-org-chain/cronos#1685
crypto-org-chain/cronos#1688
(Do not include versionDB.SetSkipVersionZero(true) in app.go)
crypto-org-chain/cronos#1751
crypto-org-chain/cronos#1759
(note: Do not include cronos storeloader and upgrades)

note:
I don't use this.
crypto-org-chain/cronos#1780
because it update rocksdbs from version 9.2.1 to 9.11.2
and grocksdb from 1.9.2 to v1.9.10-0.20250331012329-9d5f074653d1
I need to look into the differences.

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@songgaoye songgaoye requested a review from a team as a code owner July 31, 2025 03:05
@songgaoye songgaoye requested review from JayT106 and thomas-nguy and removed request for a team July 31, 2025 03:05
@songgaoye songgaoye marked this pull request as draft July 31, 2025 03:05
@songgaoye songgaoye changed the title add unit test TestVersionDB Problem: add unit test TestVersionDB Jul 31, 2025
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.83%. Comparing base (acd958e) to head (ac955af).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   31.05%   33.83%   +2.77%     
==========================================
  Files         106      114       +8     
  Lines       19006    19304     +298     
==========================================
+ Hits         5903     6531     +628     
+ Misses      12057    11694     -363     
- Partials     1046     1079      +33     
Flag Coverage Δ
integration_tests 24.03% <ø> (ø)
integration_tests_byzantine 11.32% <ø> (ø)
integration_tests_gov 11.54% <ø> (ø)
integration_tests_grpc 11.54% <ø> (ø)
integration_tests_ibc 25.27% <ø> (ø)
integration_tests_ledger 11.53% <ø> (ø)
integration_tests_slow 11.53% <ø> (ø)
integration_tests_solomachine 11.35% <ø> (ø)
integration_tests_upgrade 11.54% <ø> (ø)
unit_tests 12.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@songgaoye songgaoye changed the title Problem: add unit test TestVersionDB fix(app): update RootMultiStore interface Aug 1, 2025
sudo apt-get -y install -y build-essential libsnappy-dev zlib1g-dev libbz2-dev libgflags-dev liblz4-dev libzstd-dev cmake
- name: Build and Install RocksDB
run: |
git clone https://github.com/facebook/rocksdb.git
Copy link
Contributor Author

@songgaoye songgaoye Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a temp solution. It's better to use nix, but I don't know how to use nix.

Copy link
Contributor

@thomas-nguy thomas-nguy Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you call look at this
https://github.com/crypto-org-chain/cronos/blob/main/.github/workflows/lint.yml#L42

          nix profile install -f ./nix rocksdb
          export PKG_CONFIG_PATH=$HOME/.nix-profile/lib/pkgconfig
          export CGO_CFLAGS="$(pkg-config --cflags rocksdb)" CGO_LDFLAGS="$(pkg-config --libs rocksdb)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you call look at this https://github.com/crypto-org-chain/cronos/blob/main/.github/workflows/lint.yml#L42

          nix profile install -f ./nix rocksdb
          export PKG_CONFIG_PATH=$HOME/.nix-profile/lib/pkgconfig
          export CGO_CFLAGS="$(pkg-config --cflags rocksdb)" CGO_LDFLAGS="$(pkg-config --libs rocksdb)"

Yes, I used this in nix.yml#407, it has some problems when linkeing rocksdb. let me look into versiondb prs in the cronos project first

@songgaoye songgaoye force-pushed the songgao/versiondb_test branch 5 times, most recently from 1fed172 to 7b3b072 Compare August 1, 2025 09:13
@github-actions github-actions bot added nix and removed nix labels Aug 1, 2025
@songgaoye songgaoye marked this pull request as ready for review August 1, 2025 12:03
@github-actions

This comment has been minimized.

if-no-files-found: ignore


#test-versiondb:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it still work in progress?

Copy link
Contributor Author

@songgaoye songgaoye Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't resolve this, so I used temporary solution in test.yml

@songgaoye songgaoye marked this pull request as draft August 4, 2025 02:17
@socket-security
Copy link

socket-security bot commented Aug 5, 2025

@songgaoye songgaoye force-pushed the songgao/versiondb_test branch from a5a289b to 6e032fd Compare August 5, 2025 01:12
related prs
crypto-org-chain/cronos#1684
crypto-org-chain/cronos#1685
crypto-org-chain/cronos#1688
(not include versionDB.SetSkipVersionZero(true) in app.go)
crypto-org-chain/cronos#1751
crypto-org-chain/cronos#1759
(notice not include cronos storeloader and upgrades)
@songgaoye songgaoye force-pushed the songgao/versiondb_test branch from 2d0f901 to 8572332 Compare August 5, 2025 02:29
@songgaoye songgaoye changed the title fix(app): update RootMultiStore interface fix(app): RootMultiStore interface and version mismatch Aug 5, 2025
@songgaoye songgaoye marked this pull request as ready for review August 5, 2025 03:06
@songgaoye songgaoye force-pushed the songgao/versiondb_test branch from 00d7cbd to ac955af Compare August 5, 2025 04:32
songgaoye added a commit that referenced this pull request Aug 5, 2025
update memival,store,versondb
related prs
crypto-org-chain/cronos#1684
crypto-org-chain/cronos#1685
crypto-org-chain/cronos#1688
(Do not include versionDB.SetSkipVersionZero(true) in app.go)
crypto-org-chain/cronos#1751
crypto-org-chain/cronos#1759
(note: Do not include cronos storeloader and upgrades)

note:
I don't use this.
crypto-org-chain/cronos#1780
because it update rocksdbs from version 9.2.1 to 9.11.2
@songgaoye songgaoye marked this pull request as draft August 12, 2025 00:48
@songgaoye songgaoye closed this Aug 28, 2025
@songgaoye songgaoye deleted the songgao/versiondb_test branch September 5, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants