2018 edition

[zrzka]

2018 edition changes

• All crates (Cargo.toml) do contain edition = "2018"
• All occurrences of extern crate ... removed
• Macros imported like any other types

Warnings

• Replaced ONCE_INIT with Once::new
  • Will be deprecated in the new Rust version
• Prefixed all subcrate examples with subcrate abbreviation
  • Example crossterm_cursor/examples/cursor.rs -> crossterm_cursor/examples/cc_cursor.rs
  • I agree that it's ugly and that it has to be solved somehow, but it's polluting build logs and will be a hard error in the future, take it as a temporary fix

Imports

All imports are semantically ordered. The order is:

• Standard library
• External crates
• crate
• super
• self
• mod

I do not expect that everyone is going to maintain this order, but I consider it as a good practice to make the code more readable.

Fixes #213

[TimonPost]

Awesome! Yea I had an other order I maintained import order for a while. Thanks for putting in the work for the arranging them to an other order. I will try to keep that as default, I might want to create some code_style.md.

I'm really doubting that we might want to remove the examples from the sub crates and instead use those in /examples, because all those examples are mostly duplicated with the only difference being the namespaces

[zrzka]

I'm really doubting that we might want to remove the examples from the sub crates and instead use those in /examples, because all those examples are mostly duplicated with the only difference being the namespaces.

Yeah, that's the reason why I just prefixed them with an abbreviation (to fix warnings) and made a separate issue for this. I'm not aiming to solve the examples in this PR.

[zrzka]

Don't merge yet, I've just found that I missed the examples/program_examples. Going to fix them right now.

[zrzka]

Okay, I think it's ready for review. Couple of new things:

• Missed some extern crate ...
• Converted examples/ as well
• Removed extern crate from docs
• Added build & formatting check (stable only) for examples/program_examples

[TimonPost]

I like that some of the mod.rs files are removed, and moved a level up. Also, I like that all the crate imports are removed. There is not much to say about the changes, so thanks!

[TimonPost]

Eventually, I like to get rid of those as well, doesn't need to be done in this PR tough

[zrzka]

Can you elaborate more? Why to remove crate::...? Replace super::* with specific imports to avoid *?

[TimonPost]

Yea, * is unclear to which types your importing and can create confusion

[zrzka]

Okay, I'll do this. But if you don't mind, in a separate PR, cause this one is mainly about 2018 edition.

[TimonPost]

Yea totally fine

[TimonPost]

Just give the sign and I merge it

[zrzka]

There's no more things to do in this PR. I mean, 2018 edition related. I think it can be merged and comments can be addressed in another PRs.