-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve examples #221
Comments
Reply from #222:
IMHO this can be solved by splitting imports in the root level example and adding a comment that
I'll show you what I mean with this issue & comment in a separate branch. I can delete it if you wont like it, no problem. |
Exactly I prefer that as well because code duplication is a real pain. Just comment in the /examples/README.md, or in the example file would be good enough to tell the user that namespaces might vary on the crate they are using. |
I am going to open a PR that removes all duplicated examples in subcrates |
Fixed by #225 |
Currently there're top level examples (
crossterm
) and examples in subcrates (crossterm_cursor/example
). This is causing issues like:cargo run --example cc_cursor
My proposal is to:
This is based on the fact that most people will use
crossterm
crate only (with features) directly.The text was updated successfully, but these errors were encountered: