-
Notifications
You must be signed in to change notification settings - Fork 25
Update to crossplane-runtime v2.0.0 #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the initiative on this @twobiers!
Would you also be up for taking this update for a test drive in building a function, e.g. building on what's in https://docs.crossplane.io/v2.0/guides/write-a-composition-function-in-go/, to see if everything is working as expected there for namespaced resources? That would be really helpful 🙏
@twobiers did you get a chance to check if your PR works with the linked docs? |
I was able to successfully test this version (redirect to twobiers:v2) of the function sdk in some internal functions with namespaced and cluster scoped resource functions. |
@jbw976 can we bring this in and cut a new release ? |
No, I didn't have enough capacity yet for a full trial. If anyone wants to take this PR over, feel free to do so. |
Signed-off-by: twobiers <[email protected]>
Signed-off-by: twobiers <[email protected]>
Signed-off-by: twobiers <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
Thanks for your efforts so far @twobiers! and thank you @bakito for your testing validation, really helpful! 🙇♂️ I rebased this PR from latest on main to fix merge conflicts, mostly around the removal of provider-aws dependency in #224. I also bumped go to v1.24.8 and golangci-lint to v2.4.0 consistently across Makefile and ci.yml. I've done some testing using some local |
@jbw976 can we merge the PR then ? |
Description of your changes
Fixes #225
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Running unit tests