Skip to content

Conversation

twobiers
Copy link

Description of your changes

Fixes #225

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Running unit tests

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative on this @twobiers!

Would you also be up for taking this update for a test drive in building a function, e.g. building on what's in https://docs.crossplane.io/v2.0/guides/write-a-composition-function-in-go/, to see if everything is working as expected there for namespaced resources? That would be really helpful 🙏

@haarchri
Copy link

haarchri commented Oct 7, 2025

@twobiers did you get a chance to check if your PR works with the linked docs?

@bakito
Copy link

bakito commented Oct 7, 2025

I was able to successfully test this version (redirect to twobiers:v2) of the function sdk in some internal functions with namespaced and cluster scoped resource functions.

@haarchri
Copy link

haarchri commented Oct 7, 2025

@jbw976 can we bring this in and cut a new release ?

@twobiers
Copy link
Author

twobiers commented Oct 7, 2025

@twobiers did you get a chance to check if your PR works with the linked docs?

No, I didn't have enough capacity yet for a full trial. If anyone wants to take this PR over, feel free to do so.

@jbw976
Copy link
Member

jbw976 commented Oct 8, 2025

If anyone wants to take this PR over, feel free to do so.

Thanks for your efforts so far @twobiers! and thank you @bakito for your testing validation, really helpful! 🙇‍♂️

I rebased this PR from latest on main to fix merge conflicts, mostly around the removal of provider-aws dependency in #224. I also bumped go to v1.24.8 and golangci-lint to v2.4.0 consistently across Makefile and ci.yml.

I've done some testing using some local replace statements in a go.mod, but I also want to build/push/install a package to test the full lifecycle of a function doing v2 stuff on a live control plane too before calling this good ✅

@haarchri
Copy link

@jbw976 can we merge the PR then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to crossplane-runtime v2

4 participants