Add CROSS_CONTAINER_OPTS environment variable.
#772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently a draft since #771 will require changing how we parse the values here. |
Alexhuszagh
force-pushed
the
container_opts
branch
from
9a498e3
to
40931a7
Compare
Alexhuszagh
force-pushed
the
container_opts
branch
from
40931a7
to
4da3a9a
Compare
otavio
requested changes
Jun 11, 2022
Rename `DOCKER_OPTS` to `CROSS_CONTAINER_OPTS`, and currently prefer `CROSS_CONTAINER_OPTS` to `DOCKER_OPTS`, although both are still valid. Closes cross-rs#770.
Alexhuszagh
force-pushed
the
container_opts
branch
from
4da3a9a
to
5d6855b
Compare
|
👎 Rejected by code reviews |
|
ping @otavio |
otavio
approved these changes
Jun 12, 2022
|
bors r=Emilgardis |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
DOCKER_OPTStoCROSS_CONTAINER_OPTS, and currently preferCROSS_CONTAINER_OPTStoDOCKER_OPTS, although both are still valid.Closes #770.