Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of docker options. #771

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

Alexhuszagh
Copy link
Contributor

Fix parsing DOCKER_OPTS to correctly parse them as shell words, rather than splitting on whitespace.

Closes #769.

Fix parsing `DOCKER_OPTS` to correctly parse them as shell words, rather
than splitting on whitespace.

Closes cross-rs#769.
@Alexhuszagh
Copy link
Contributor Author

Alexhuszagh commented Jun 9, 2022

I think parsing them as a Unix shell is the best idea, since users are likely going to be using a Unix shell, it handles simple cases well, and even on Windows CMD this works identically for most default cases (unsure about Powershell), and you can almost always provide the correct arguments in the shell regardless.

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works in powershell too, I'm sure there's edge cases but this is better than being completely wrong most of the time

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 9, 2022

Build succeeded:

@bors bors bot merged commit ed7c67a into cross-rs:main Jun 9, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added the A-container-engine Area: container engines label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-container-engine Area: container engines bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCKER_OPTS is Incorrectly Parsed
3 participants