-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support musl builds along with packaging #274
Conversation
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 68.90% 68.94% +0.04%
==========================================
Files 128 128
Lines 14888 14888
==========================================
+ Hits 10259 10265 +6
+ Misses 4629 4623 -6
Continue to review full report at Codecov.
|
Currenty the build fails for musl with
Which is a bit surprising since based on the output the flags are set correctly. |
678f092
to
4c32389
Compare
Also pin the rust version used for building the project via rust-toolchain file.
This helps launch tremor easily from deployments relying on our packaging.
These can be used later when we automate packaging as part of the release CI.
Also ensure target-feature flags (for simd-json compilation) gets passed only on release builds for the alpine-linux-musl targets. For dev builds, we do it via target-cpu flag.
4c32389
to
2b86a47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some clippy love but LGTM otherwise!
Until the clippy bug generating a ton of warnings makes it to stable: rust-lang/rust-clippy#5535 Also pin clippy checks in CI for the same rust version as the one specified in the project rust-toolchain file --- Fix test issues seen with 1.44 pre-emptively. We should also pin rust versions on those CI runs now (will be done as part of a separate cleanup).
34af468
to
0c069c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Package formats supported currently are archive (tar.gz) and deb.
Some documentation at: https://github.com/wayfair-tremor/tremor-runtime/tree/musl_plus_packaging/packaging