Track and release state blocks on device release #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSnowfall
force-pushed
the
sb-tracking
branch
from
b10824d to
c758c0b
Compare
|
I've tested the PR with Cossacks II in Wine and everything seems fine now, even after multiple in-game-then-back-to-main-menu switches. I doubt d3d8to9 can be used with the game on Windows anyway, because it force loads the d3d8.dll from the system32 path (or syswow64 on modern systems). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to VS, shader definitions and PS, some games create state blocks that they never delete and expect the D3D8 runtime to perform this cleanup on device release (this doesn't happen in D3D9). Should help improve, if not completely address #92, but needs some wider testing.