Skip to content

Issue #75 Add logic to get qcow2 location for 4.2 cluster #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkumar merged 1 commit into from
Sep 10, 2019
Merged

Issue #75 Add logic to get qcow2 location for 4.2 cluster #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions createdisk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,13 @@ function create_crc_libvirt_sh {
function create_qemu_image {
local destDir=$1

sudo cp /var/lib/libvirt/images/${VM_PREFIX}-master-0 $destDir
sudo cp /var/lib/libvirt/images/${VM_PREFIX}-base $destDir
if [ -f /var/lib/libvirt/images/${VM_PREFIX}-master-0 ]; then
Copy link
Contributor

@cfergeau cfergeau Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cleaner to check for libvirt storage pool existence, get the path from there, and use it. But given our use of sh to do all of this, the way you did is much easier/efficient.

sudo cp /var/lib/libvirt/images/${VM_PREFIX}-master-0 $destDir
sudo cp /var/lib/libvirt/images/${VM_PREFIX}-base $destDir
else
sudo cp /var/lib/libvirt/openshift-images/${VM_PREFIX}/${VM_PREFIX}-master-0 $destDir
sudo cp /var/lib/libvirt/openshift-images/${VM_PREFIX}/${VM_PREFIX}-base $destDir
fi

sudo chown $USER:$USER -R $destDir
${QEMU_IMG} rebase -b ${VM_PREFIX}-base $destDir/${VM_PREFIX}-master-0
Expand Down