Issue #75 Add logic to get qcow2 location for 4.2 cluster #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
approved these changes
Sep 9, 2019
Contributor
cfergeau
left a comment
cfergeau
left a comment
There was a problem hiding this comment.
"we are copying the correct file" in the commit log
|
|
||
| sudo cp /var/lib/libvirt/images/${VM_PREFIX}-master-0 $destDir | ||
| sudo cp /var/lib/libvirt/images/${VM_PREFIX}-base $destDir | ||
| if [ -f /var/lib/libvirt/images/${VM_PREFIX}-master-0 ]; then |
Contributor
There was a problem hiding this comment.
Would be cleaner to check for libvirt storage pool existence, get the path from there, and use it. But given our use of sh to do all of this, the way you did is much easier/efficient.
Due to openshift/installer#1956 , now by default the location of the qcow2 images are part of `/var/lib/libvirt/openshift/<cluster_name>_<random_hash>` so this change will make sure we are copying the correct file as part of our CI.
praveenkumar
force-pushed
the
issue_75
branch
from
ae43b08 to
c66c4ca
Compare
This was referenced Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to openshift/installer#1956 , now
by default the location of the qcow2 images are part of
/var/lib/libvirt/openshift/<cluster_name>_<random_hash>sothis change will make sure we are copy correct file as part of
our CI.