-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #4279 Fix case sensitive WSL2 validation check #4280
Issue #4279 Fix case sensitive WSL2 validation check #4280
Conversation
The WSL validation check assumes that the name "Microsoft" is capitalized but this is not true in all cases. Signed-off-by: Allain Legacy <[email protected]>
Hi @alegacy. Thanks for your PR. I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, gbraad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks. The test can be stricter, as it contains |
@cfergeau @gbraad @praveenkumar ... some tests appear to be failing. I don't think any of them are affected by my changes. Do these tests have a history of intermittent failures? Should I re-trigger and hope for the best or is there some automation that will come around to do that? |
/retest-required |
@alegacy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Don't worry about the tests, they are unfortunately very unreliable :( |
The WSL validation check assumes that the name "Microsoft" is capitalized but this is not true in all cases.
Fixes: Issue #4279
Relates to: Issue #2131 , PR #2323
Solution/Idea
Enhancing WSL validation check to be case-insensitive to prevent users from attempting to run on an unsupported platform.
Proposed changes
Updated validation check to force
toLower(...)
on the output of/proc/version
prior to searching for the target substring ofmicrosoft
.Testing
Validation check now prevents running on systems running WSL regardless of the capitalization of the word Microsoft.