-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] WSL2 validation check is currently case senstive #4279
Comments
Looks like the issue is the case sensitivity of the validation check. I'm willing to submit a PR if that's agreed upon as the cause. |
@alegacy Are you trying to run |
@praveenkumar yes, I didn’t realize that wasn’t supported so I spent a bit of time debugging why the libvirt instance wasn’t starting. Thru a bunch of google queries i eventually discovered that wasn’t supported and that there was a validation check that should have saved me earlier on. |
@alegacy right, Better to run crc directly on the windows machine instead running it on a wsl environment which need wsl virtualization and nested virt support. I am closing this issue since it is a non supported setup. Please create a new issue if you face problem with running crc directly on windows machine. |
@praveenkumar perhaps I wasn’t clear. The issue that I raised was against the validation check that should have flagged this as an unsupported configuration right from the beginning. That check is looking for the word I was suggesting that the validation check could have been improved and I am willing to push a PR to do that. |
Ah ok, you are referring to this check crc/pkg/crc/preflight/preflight_checks_linux.go Lines 33 to 45 in 71b8eb6
A PR to improve it is definitely welcome! |
@alegacy Please open a PR to fix this. |
The WSL validation check assumes that the name "Microsoft" is capitalized but this is not true in all cases. Signed-off-by: Allain Legacy <[email protected]>
The WSL validation check assumes that the name "Microsoft" is capitalized but this is not true in all cases. Signed-off-by: Allain Legacy <[email protected]>
General information
crc setup
before starting it (Yes/No)? YesCRC version
CRC status
CRC config
- consent-telemetry : yes
Host Operating System
Steps to reproduce
Expected
Should fail to start on WSL2 since not supported. See issue #2131 and fix #2323.
Actual
crc start
attempts to start the VM and fails.Logs
The output of
/proc/version
is this:Linux version 5.15.153.1-microsoft-standard-WSL2 (root@941d701f84f1) (gcc (GCC) 11.2.0, GNU ld (GNU Binutils) 2.37) #1 SMP Fri Mar 29 23:14:13 UTC 2024
The text was updated successfully, but these errors were encountered: