Cancel touch events when treating them as mouse events #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some cross-browser testing, I noticed that Crafty's mouse events were being triggered twice on mobile. I'm fairly certain this is because the browser was also mapping touch events to mouse events.
The best solution seems to be to call
preventDefault()on the touch event when forwarding to the mouse system. I believe that when Crafty itself handles touch/mouse this is already done; it's just missing when we forward touch events to mouse events.Tagging @mucaho since he's done much more work the touch/mouse systems than I have.