-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.9.0 #1166
Comments
There are a couple of tests failing on saucelabs, due to "Unsupported OS/browser/version/device combo". I'll probably have to update some combos to more recent systems. |
Updated the tests targets in this commit, they now pass. (Essentially we try to test the oldest browsers we support in addition to the most recent. SauceLabs makes it easy to specify the most recent with the |
Here is the first release candidate. |
In doing some browser checks, I noticed the following small issues:
|
I think I've figured out the touch issue; potential fix here |
What I also noticed is the documentation in the beta that is no longer working: https://github.com/craftyjs/Crafty/blob/develop/src/spatial/collision.js#L483
Since the The whole fixing of that proved to be quite complex, but I'm my game I did it like this: So instead of using the 'Moved' event, I used the |
Yeah, this is definitely one of the bigger breaking changes in this release -- it essentially halved the cost of movement (including halving the number of collision checks), though, so it seemed worthwhile from a perf standpoint. The simplest solution that I see is to just provide Does that seem like it would work for your use case? |
Not sure what really should be done. It works in my case, but to have everything done properly, it does require some work. Crafty could help out I guess, but I'm not sure if it should be an option or just a method to convert that the user can decide to use it or not. I would prefer the method so that the developer can make the choice for each specific use case. |
Created a third rc that fixes the touch issue. At this point I've checked the rendering in everything but IE9 and the iPhone. It does pass the basic DOM/Cavnas "render a square" tests in those browsers. |
Created a wiki page that tries to cover likely pitfalls of the various breaking changes. Not sure I have the best perspective on what's helpful here, though! @matthijsgroen feel free to update that page as you see fit, since you've just done such an upgrade. |
Well the only thing I encountered was that |
Is there a public url to test? I can test Safari iphone |
Sure, I've been using two slightly wonky "games" to test with:
|
Both demos work exactly the same on Safari on iPhone as they do in the browser for me. |
Thanks for testing that. I should be able to prepare the small site updates necessary and run the release this weekend. |
Merged to master and updated the site, so closing this issue! Never did manually test in IE9, but that's increasingly irrelevant, so 🤷♂️ (And we do have automated tests that run there.) |
🎉🍰 |
Browser checks
Let's make sure that we at least nominally work in the full list of browsers (i.e. a basic scene will render.)
The text was updated successfully, but these errors were encountered: