Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of trailing 0 in fixed format to_chars with unspecified precision #793

Merged
merged 8 commits into from
Jan 18, 2025

Conversation

mborland
Copy link
Member

No description provided.

@mborland mborland force-pushed the to_chars_10s branch 2 times, most recently from 1200944 to c3c1e26 Compare January 18, 2025 01:58
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.9%. Comparing base (ee92e74) to head (dccbab7).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/decimal/charconv.hpp 58.4% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #793     +/-   ##
=========================================
+ Coverage     98.9%   98.9%   +0.1%     
=========================================
  Files          225     226      +1     
  Lines        16940   16949      +9     
  Branches      1806    1807      +1     
=========================================
+ Hits         16739   16748      +9     
  Misses         201     201             
Files with missing lines Coverage Δ
include/boost/decimal/detail/memcpy.hpp 100.0% <ø> (ø)
test/crash_report_1.cpp 100.0% <100.0%> (ø)
test/test_to_chars.cpp 100.0% <ø> (ø)
include/boost/decimal/charconv.hpp 86.8% <58.4%> (+0.2%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee92e74...dccbab7. Read the comment docs.

@mborland mborland merged commit 227588c into develop Jan 18, 2025
73 of 75 checks passed
@mborland mborland deleted the to_chars_10s branch January 18, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant