Skip to content

[vector.modifiers] Old concepts cannot be “modeled” #7836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jensmaurer merged 2 commits into from
Apr 14, 2025
Merged

[vector.modifiers] Old concepts cannot be “modeled” #7836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b0f5c0
Update containers.tex
xmcgcg Apr 14, 2025
13d6465
Apply suggestions from code review
xmcgcg Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions source/containers.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10082,7 +10082,8 @@
\tcode{first}
and
\tcode{last})
and no reallocations if iterators \tcode{first} and \tcode{last} are of forward, bidirectional, or random access categories.
and no reallocations if
\tcode{InputIterator} meets the \oldconcept{ForwardIterator} requirements.
Comment on lines -10085 to +10086
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether the change in these lines is desired or editorial. It seems that the old wording can also be interpreted as "[...] if InputIterator meets the Cpp17ForwardIterator requirements or models forward_iterator".

It makes order
$N$
calls to the copy constructor of
Expand Down Expand Up @@ -10385,7 +10386,7 @@
\end{itemize}
For the declarations taking a pair of \tcode{InputIterator},
performs at most one reallocation if
\tcode{InputItera\-tor} models \oldconcept{ForwardIterator}.
\tcode{InputItera\-tor} meets the \oldconcept{ForwardIterator} requirements.
\end{itemdescr}

\indexlibrarymember{erase}{vector}%
Expand Down
Loading