[vector.modifiers] Old concepts cannot be “modeled” #7836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
requested changes
Apr 14, 2025
Co-authored-by: Jonathan Wakely <[email protected]>
jwakely
approved these changes
Apr 14, 2025
jensmaurer
approved these changes
Apr 14, 2025
Comment on lines
-10085
to
+10086
| and no reallocations if iterators \tcode{first} and \tcode{last} are of forward, bidirectional, or random access categories. | ||
| and no reallocations if | ||
| \tcode{InputIterator} meets the \oldconcept{ForwardIterator} requirements. |
Contributor
There was a problem hiding this comment.
I'm not sure whether the change in these lines is desired or editorial. It seems that the old wording can also be interpreted as "[...] if InputIterator meets the Cpp17ForwardIterator requirements or models forward_iterator".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[vector.modifiers] p3 says:
“Model” should not be used on old Cpp17XXX concepts, “meet the requirements of” should be used instead.
[vector.cons] p10 is also updated for consistency.