Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add span to driver runs #182

Merged
merged 3 commits into from
May 2, 2022
Merged

Add span to driver runs #182

merged 3 commits into from
May 2, 2022

Conversation

vkgnosis
Copy link
Contributor

Test Plan

see changed log messages

@vkgnosis vkgnosis requested a review from a team as a code owner April 29, 2022 09:36
@sunce86
Copy link
Contributor

sunce86 commented Apr 29, 2022

What does this do? I tried to check the docs but still not sure.

@vkgnosis
Copy link
Contributor Author

Follow up from #178 .
Log messages are a point in time while spans are a span of time. In practice this means that for log messages like our transport logs that were previous hard to attach to a high level event, they will now say [driver run id = 123] . So you can easily tell which low level log message belongs to which driver run.

@vkgnosis
Update crates/solver/src/driver.rs
c40e44c 
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
@vkgnosis vkgnosis enabled auto-merge (squash) May 2, 2022 07:44
@vkgnosis vkgnosis merged commit 3011d69 into main May 2, 2022
@vkgnosis vkgnosis deleted the driver-span branch May 2, 2022 07:47
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkgnosis @sunce86 @nlordell