Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tracing span for maintenance #178

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Use tracing span for maintenance #178

merged 2 commits into from
Apr 29, 2022

Conversation

vkgnosis
Copy link
Contributor

I was looking at logs and reading about tracing::span . The spans are nice because they give context to why log messages are emitted. We already use them for for handling api requests so we know whether a log message originates from the process of handling a request and we give requests an id.
Likewise by adding a span here we will see which lower level log messages originate from maintenance.
I might add spans to a couple of other places in the future that I'm still thinking about.

Test Plan

run and observe the extra information (should be visible in CI)

@vkgnosis vkgnosis requested a review from a team as a code owner April 28, 2022 15:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #178 (69dae80) into main (412f36d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 69dae80 differs from pull request most recent head f49375e. Consider uploading reports for the commit f49375e to get more accurate results

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   64.81%   64.83%   +0.01%     
==========================================
  Files         185      185              
  Lines       38398    38398              
==========================================
+ Hits        24889    24895       +6     
+ Misses      13509    13503       -6     

@fleupold
Copy link
Contributor

Awesome change! For debugging, it would be great to have a tracing span on the auction id in the solver (so that it's easy to filter logs of a particular "run")

Copy link
Contributor

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that driver run loop by auction ID would be a nice span to have as well.

@vkgnosis vkgnosis enabled auto-merge (squash) April 29, 2022 08:08
@vkgnosis vkgnosis merged commit eaf91b5 into main Apr 29, 2022
@vkgnosis vkgnosis deleted the tracing branch April 29, 2022 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants