Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings subtitle fix #31

Merged
merged 3 commits into from
May 15, 2018
Merged

Conversation

DimitarChristoff
Copy link
Contributor

  • expected: produce <h1 class="title ...">
  • actual: produces <h1 class="title subtitle ...">

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.469% when pulling 25c8de0 on DimitarChristoff:headings-subtitle-fix into f100f59 on couds:master.

@couds couds merged commit dd0126c into couds:master May 15, 2018
@couds
Copy link
Owner

couds commented May 15, 2018

Hi @DimitarChristoff Thanks for you contribution

@DimitarChristoff DimitarChristoff deleted the headings-subtitle-fix branch May 15, 2018 16:40
@DimitarChristoff
Copy link
Contributor Author

DimitarChristoff commented May 15, 2018

@couds no worries. let me know when you plan a release. there are some constructs missing - like grouped buttons etc that I have done locally, may push if i get a chance.

also, Icons documentation is lacking, should list the 2 icons you ship with and potentially fix the .sass file by removing the ; etc from .scss - in fairness, O'd even convert .sass to .scss throughout :)

having the burger icon is probably pointless anyway - eg:

  <a role="button" class="navbar-burger" aria-label="menu" aria-expanded="false">
      <span aria-hidden="true"></span>
      <span aria-hidden="true"></span>
      <span aria-hidden="true"></span>
    </a>

adding is-active actually animates the hamburger quite nicely, loads better than a static icon.

but yes, there was no mention about importing a CSS file when you consume it and it has not affected my usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants