-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form.Label htmlFor default value needs to be removed #27
Comments
Hi @DimitarChristoff, Thanks for using this library PR are more than welcome please open one to fix this behavior |
DimitarChristoff
added a commit
to DimitarChristoff/react-bulma-components
that referenced
this issue
May 14, 2018
…out an explicit htmlFor. fixes couds#27
DimitarChristoff
added a commit
to DimitarChristoff/react-bulma-components
that referenced
this issue
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/couds/react-bulma-components/blob/master/src/components/form/components/label.js#L19
the problem is in this:
this produces
<label class="label" for> ...
which means clicking on the Foo text does not give focus to the input. workaround is<Form.Label htmlFor={null}>
but it's not nice.happy to send a PR updating it and also adding the case to the storybook.
The text was updated successfully, but these errors were encountered: