Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Deny building with OpenSSL 3.0 #872

Merged
merged 4 commits into from
Nov 2, 2021
Merged

core: Deny building with OpenSSL 3.0 #872

merged 4 commits into from
Nov 2, 2021

Commits on Nov 1, 2021

  1. soter: Fail the build with OpenSSL 3.0 

    As I said in the comment, it's pretty risky at the moment to build
Themis against OpenSSL 3.0, so let's explicitly disallow it.

This applies to previously released versions too, but I can't be
bothered to issue a hotfix for that. Binary releases for Linux are not
affected (they still use OpenSSL 1.1), Homebrew release for macOS will
be patched up to use OpenSSL 1.1 separately, and whoever is brave enough
to build Themis from source manually -- you will be warned in docs.
    @ilammy
    ilammy committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    02e7595 View commit details
    Browse the repository at this point in the history

  2. CI: Verify that OpenSSL 3.0 build fails 

    Throw in an extra step to ensure that OpenSSL 3.0 is indeed failing the
build. At the moment only macOS Homebrew seems to have OpenSSL 3.0
available, so test with that. Linux distros are currently working on
transitions too, but testing just one OS should be fine at the moment.
    @ilammy
    ilammy committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    6a5d9c7 View commit details
    Browse the repository at this point in the history

  3. changelog: Mention compilation error in the changelog 

    The intention here is that if we release Themis 0.14 as is, without
OpenSSL 3.0 support, then people should be aware of this #error
directive that will fail their builds.
    @ilammy
    ilammy committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    0b995bd View commit details
    Browse the repository at this point in the history

  4. Makefile: Allow to opt-in OpenSSL 3 usage for experts 

    Provide a not-really-documented way to build Themis with OpenSSL 3
by setting environment variable WITH_EXPERIMENTAL_OPENSSL_3_SUPPORT.
    @ilammy
    ilammy committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    30df5f8 View commit details
    Browse the repository at this point in the history