core: Deny building with OpenSSL 3.0 #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilammy
added
core
ilammy
requested review from
ignatk,
Lagovas,
storojs72 and
vixentael
as code owners
vixentael
approved these changes
Nov 1, 2021
As I said in the comment, it's pretty risky at the moment to build Themis against OpenSSL 3.0, so let's explicitly disallow it. This applies to previously released versions too, but I can't be bothered to issue a hotfix for that. Binary releases for Linux are not affected (they still use OpenSSL 1.1), Homebrew release for macOS will be patched up to use OpenSSL 1.1 separately, and whoever is brave enough to build Themis from source manually -- you will be warned in docs.
Throw in an extra step to ensure that OpenSSL 3.0 is indeed failing the build. At the moment only macOS Homebrew seems to have OpenSSL 3.0 available, so test with that. Linux distros are currently working on transitions too, but testing just one OS should be fine at the moment.
The intention here is that if we release Themis 0.14 as is, without OpenSSL 3.0 support, then people should be aware of this #error directive that will fail their builds.
Provide a not-really-documented way to build Themis with OpenSSL 3 by setting environment variable WITH_EXPERIMENTAL_OPENSSL_3_SUPPORT.
ilammy
force-pushed
the
deny-openssl-3.0
branch
from
97624f1
to
30df5f8
Compare
|
With the base branch merged, I found it easier to rebase the whole thing to resolve merge conflicts. Ugh, GitHub you don't help in the slightest here! >_< I've also added one more commit that allows to build Themis with OpenSSL 3.0 if you say the magic word. I realized that I will need a way to build it without failing while working on the transition. So developers can ask for and avoid triggering that |
best feature |
vixentael
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the time being Themis and Soter do not support OpenSSL 3.0. The code seems to build fine but it fails the tests, so we're not sure that it is safe to use Soter with OpenSSL 3.0. It's pretty risky at the moment to build Themis against OpenSSL 3.0, so let's explicitly disallow it.
This applies to previously released versions too, but I can't be bothered to issue a hotfix for that. Binary releases for Linux are not affected (they still use OpenSSL 1.1), Homebrew release for macOS will be patched up to use OpenSSL 1.1 separately, and whoever is brave enough to build Themis from source manually – you will be warned in docs.
Throw in an extra step on CI to ensure that OpenSSL 3.0 is indeed failing the build. At the moment only macOS Homebrew seems to have OpenSSL 3.0 available, so test with that. Linux distros are currently working on transitions too, but testing just one OS should be fine at the moment.
To make conflict resolution easier, this PR includes #871.
Checklist