Migrate to "afl++" from "afl" #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate to "afl++" from "afl" The original "afl" [1] has been abandoned and is not maintained since 2017. "afl++" [2] is its replacement. Since it's a fork, it has mostly compatible command line, and more features. [1]: http://lcamtuf.coredump.cx/afl/ [2]: https://github.com/AFLplusplus/AFLplusplus The original afl is currently being phased out from distributions. In particular, it's gone from whatever repo list GitHub Actions use, breaking our build. Migrate to "afl++" instead. Not all operating systems ship with "afl++" though. For example, it's still not available in binary form on macOS via Homebrew. Therefore, don't jump the gun and don't update the Makefile to use "afl++"-only features. (However, it would be nice to use them if available.) * Pin "fuzzing" job to Ubuntu 18.04 As noted in the comment, GitHub Actions runners are schizophrenic and sometimes believe that they come from the future where the latest Ubuntu image works correctly. Don't let them be fooled, use 18.04 for now. (cherry picked from commit 0c6a44d) Ignore changes in CHANGELOG.md, there is no "Unreleased" section on the "stable" branch. It will get here in due time.
|
Oh well, it seems even more stuff needs to be backported as the jobs are failing. Since this PR touches some Themis Core files, it should trigger all the jobs and expose whatever is currently broken for |
vixentael
approved these changes
Feb 2, 2021
iamnotacake
approved these changes
Feb 2, 2021
This was referenced Feb 3, 2021
|
I've submitted fixes to the issues above. These are separate pull requests so that history clearly shows what has been cherry-picked from where (instead of one squashed commit "fix stuff by integrating all these changes"). Once those three are all merged and this one is added on top, I'd expect |
vixentael
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #769, backport #766 onto
stabletoo to fix the build.Ignore changes in CHANGELOG.md, there is no "Unreleased" section on the
stablebranch. It will get here in due time.Checklist
Oh why yes, it is covered.