Migrate to "afl++" from "afl" #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original "afl" [1] has been abandoned and is not maintained since 2017. "afl++" [2] is its replacement. Since it's a fork, it has mostly compatible command line, and more features. [1]: http://lcamtuf.coredump.cx/afl/ [2]: https://github.com/AFLplusplus/AFLplusplus The original afl is currently being phased out from distributions. In particular, it's gone from whatever repo list GitHub Actions use, breaking our build. Migrate to "afl++" instead. Not all operating systems ship with "afl++" though. For example, it's still not available in binary form on macOS via Homebrew. Therefore, don't jump the gun and don't update the Makefile to use "afl++"-only features. (However, it would be nice to use them if available.)
ilammy
added
core
Well, you were not wrong. Unfortunately. Though it has nothing to do with your changes, which are good IMO. Problems with non-interactive 32-bit libc installation on Ubuntu 20.04? 🤔 |
|
Oh well... It worked in my fork before I created a PR. IDK, just let's wait until GitHub Actions get their act together and try rerunning the build tomorrow, or later. |
|
I restarted GHA, but it's still failing with the same error. Let's wait tomorrow indeed ¯_(ツ)_/¯ |
vixentael
approved these changes
Jan 27, 2021
Fun fact: Docs say that It works with 18.04 and does not work with 20.04. Move fast, break things ¯\_(ツ)_/¯ |
As noted in the comment, GitHub Actions runners are schizophrenic and sometimes believe that they come from the future where the latest Ubuntu image works correctly. Don't let them be fooled, use 18.04 for now.
ilammy
added a commit
that referenced
this pull request
Feb 3, 2021
* Migrate to "afl++" from "afl" The original "afl" [1] has been abandoned and is not maintained since 2017. "afl++" [2] is its replacement. Since it's a fork, it has mostly compatible command line, and more features. [1]: http://lcamtuf.coredump.cx/afl/ [2]: https://github.com/AFLplusplus/AFLplusplus The original afl is currently being phased out from distributions. In particular, it's gone from whatever repo list GitHub Actions use, breaking our build. Migrate to "afl++" instead. Not all operating systems ship with "afl++" though. For example, it's still not available in binary form on macOS via Homebrew. Therefore, don't jump the gun and don't update the Makefile to use "afl++"-only features. (However, it would be nice to use them if available.) * Pin "fuzzing" job to Ubuntu 18.04 As noted in the comment, GitHub Actions runners are schizophrenic and sometimes believe that they come from the future where the latest Ubuntu image works correctly. Don't let them be fooled, use 18.04 for now. (cherry picked from commit 0c6a44d) Ignore changes in CHANGELOG.md, there is no "Unreleased" section on the "stable" branch. It will get here in due time.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
aflhas been abandoned and is not maintained since 2017.afl++is its successor. Since it's a fork, it has mostly compatible command line, and more features.The original afl is currently being phased out from distributions. In particular, it's gone from whatever repo list GitHub Actions use, breaking our build. Migrate to afl++ instead.
Not all operating systems ship with afl++ though. For example, it's still not available in binary form on macOS via Homebrew. Therefore, don't jump the gun and don't update the Makefile to use afl++-only features. (However, it would be nice to use them if available.)
The timing could not have been better! GitHub Actions broke the build again... I guess it's the “upgrade January” for them.
I'm tired of this so this is the last PR that I submit or merge this week. If it's red then it's red.
Checklist