Correct detecting of installing paths for i386 #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approach we used previously, was based on getting the `cc -dumpmachine` value as a part of the target directory. It works well on x86_64, but on i386 the incorrect directory was drawn up.
= x86_64
`[/usr]/lib/x86_64-linux-gnu`
```
$ cc -dumpmachine
x86_64-linux-gnu
$ ld --verbose | grep SEARCH_DIR | tr -s ' ;' \\012
SEARCH_DIR("=/usr/local/lib/x86_64-linux-gnu")
SEARCH_DIR("=/lib/x86_64-linux-gnu")
SEARCH_DIR("=/usr/lib/x86_64-linux-gnu")
SEARCH_DIR("=/usr/lib/x86_64-linux-gnu64")
SEARCH_DIR("=/usr/local/lib64")
SEARCH_DIR("=/lib64")
SEARCH_DIR("=/usr/lib64")
SEARCH_DIR("=/usr/local/lib")
SEARCH_DIR("=/lib")
SEARCH_DIR("=/usr/lib")
SEARCH_DIR("=/usr/x86_64-linux-gnu/lib64")
SEARCH_DIR("=/usr/x86_64-linux-gnu/lib")
```
= i386
`[/usr]/lib/i686-linux-gnu`
```
$ cc -dumpmachine
i686-linux-gnu
$ ld --verbose | grep SEARCH_DIR | tr -s ' ;' \\012
SEARCH_DIR("=/usr/local/lib/i386-linux-gnu")
SEARCH_DIR("=/lib/i386-linux-gnu")
SEARCH_DIR("=/usr/lib/i386-linux-gnu")
SEARCH_DIR("=/usr/local/lib32")
SEARCH_DIR("=/lib32")
SEARCH_DIR("=/usr/lib32")
SEARCH_DIR("=/usr/local/lib")
SEARCH_DIR("=/lib")
SEARCH_DIR("=/usr/lib")
SEARCH_DIR("=/usr/i686-linux-gnu/lib32")
SEARCH_DIR("=/usr/i686-linux-gnu/lib")
```
So the suggested solution is to simply use `i386-linux-gnu` instead of `i686-linux-gnu`, which works well on all i386 Debian/Ubuntu distributives.
3 tasks
|
Since we suddenly got two PRs on the same issue, take the best from both and update the PR #651. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach we used previously, was based on getting the
cc -dumpmachinevalue as a part of the target directory. It works well on x86_64, but on i386 the incorrect directory was drawn up.= x86_64
[/usr]/lib/x86_64-linux-gnu= i386
[/usr]/lib/i686-linux-gnuSo the suggested solution is to simply use
i386-linux-gnuinstead ofi686-linux-gnu, which works well on all i386 Debian/Ubuntu distributives.