Use correct libdir for multiarch Debian #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian multiarch is a little bit complicated, one particularly important thing is the installation directory for libraries. For multiarch-enabled packages it should include the "target triple". However, for Debian this is not your usual target triple, but *normalized* target triple [1]. [1]: https://wiki.debian.org/Multiarch/Tuples This is not really noticeable on x86_64 but on 32-bit x86 systems compilers tend to report {i386,i486,i586,i686}-linux-gnu when the "correct" one is only i386-linux-gnu. We should use the correct, normalized triplet since that's what dynamic loader uses. If the library is installed into an incorrect multiarch subdirectory then it will fail to load. Instead of asking the compiler, ask dpkg for the multiarch-correct triplet for the system on which we are building the package. We always build packages targeting the host system so this is correct approach.
ilammy
added
infrastructure
Optimize distro detection a bit to avoid duplicating code for Debian and Ubuntu which are currently the same. Co-authored-by: Dmytro Shapovalov <[email protected]>
shadinua
approved these changes
Jun 4, 2020
vixentael
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian multiarch is a little bit complicated, one particularly important thing is the installation directory for libraries. For multiarch-enabled packages it should include the "target triple". However, for Debian this is not your usual target triple, but normalized target triple.
This is not really noticeable on x86_64 but on 32-bit x86 systems compilers tend to report
{i386,i486,i586,i686}-linux-gnuwhen the correct one is onlyi386-linux-gnu.We should use the correct, normalized triplet since that's what dynamic loader uses. If the library is installed into an incorrect multiarch subdirectory then it will fail to load.
Instead of asking the compiler, ask dpkg for the multiarch-correct triplet for the system on which we are building the package. We always build packages targeting the host system so this is correct approach.
Checklist
Change is covered by automated tests(only on BuiltBot)Changelog is updated(nothing notable)