Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test all matrix configurations #617

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Test all matrix configurations #617

merged 1 commit into from
Apr 1, 2020

Conversation

ilammy
Copy link
Collaborator

@ilammy ilammy commented Mar 30, 2020

Add fail-fast: false to matrix testing strategies so that they continue testing other variant instead of auto-canceling them. For example, if only Node.js v8 fails, we don't want the Node.js v12 job to be canceled. This might be different in future cases, but everywhere we use "strategy: matrix" now, we'd like all items to be tested regardless of their siblings' failures.

Checklist

  • Change is covered by automated tests
  • Benchmark results are attached
  • The coding guidelines are followed
  • Public API has proper documentation

@ilammy
Test all matrix configurations
e580ed2 
Add "fail-fast: false" to matrix testing strategies so that they
continue testing other variant instead of auto-canceling them.
For example, if only Node.js v8 fails, we don't want the Node.js v12
job to be canceled. This might be different in future cases, but
everywhere we use "strategy: matrix" now, we'd like all items to be
tested regardless of their siblings' failures.
@ilammy ilammy added the infrastructure Automated building and packaging label Mar 30, 2020
Lagovas
Lagovas approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fail-fast good when we have limited cpu time on CI and bad in developing when you see only one fail, fix, push again and see one more fail instead fixing all of them)

@ilammy ilammy merged commit 6ecd0bc into cossacklabs:master Apr 1, 2020
@ilammy ilammy deleted the fail-slow branch April 1, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vixentael vixentael vixentael approved these changes

@Lagovas Lagovas Lagovas approved these changes

Assignees
No one assigned
Labels
infrastructure Automated building and packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilammy @vixentael @Lagovas