Skip to content

Commit

Permalink
Test all matrix configurations (#617)
Browse files Browse the repository at this point in the history
Add "fail-fast: false" to matrix testing strategies so that they
continue testing other variant instead of auto-canceling them.
For example, if only Node.js v8 fails, we don't want the Node.js v12
job to be canceled. This might be different in future cases, but
everywhere we use "strategy: matrix" now, we'd like all items to be
tested regardless of their siblings' failures.
  • Loading branch information
ilammy authored Apr 1, 2020
1 parent 35db08b commit 6ecd0bc
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/test-core.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
fail-fast: false
steps:
- name: Install system dependencies
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-go.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
strategy:
matrix:
go: ['1.11.13', '1.12.17', '1.13.8', '1.14']
fail-fast: false
steps:
- name: Install system dependencies
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-java.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
fail-fast: false
steps:
- name: Install system dependencies
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-nodejs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
- 8.x # old LTS
- 10.x # current LTS
- 12.x # current stable
fail-fast: false
steps:
- name: Install system dependencies
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-python.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
strategy:
matrix:
python: [python2, python3]
fail-fast: false
env:
PYTHON: ${{ matrix.python }}
services:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-wasm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
- 8.x # old LTS
- 10.x # current LTS
- 12.x # current stable
fail-fast: false
steps:
- name: Install system dependencies
run: |
Expand Down

0 comments on commit 6ecd0bc

Please sign in to comment.